fix(CVE-2026-1615): Replace jsonpath with jsonpath-plus to fix security vulnerability#247
Open
woo-industries wants to merge 2 commits intoFlagsmith:mainfrom
Open
fix(CVE-2026-1615): Replace jsonpath with jsonpath-plus to fix security vulnerability#247woo-industries wants to merge 2 commits intoFlagsmith:mainfrom
woo-industries wants to merge 2 commits intoFlagsmith:mainfrom
Conversation
Author
|
I can't get the formatting for the CHANGELOG.md right because it was Also I don't know what to do about the version number for the changelog. Feel free to advise ! I've also squashed this to one commit per your contribution guidance ☮️ |
woo-industries
changed the title
woo-industries
force-pushed
the
fix/jsonpath
branch
from
cf588d1 to
42a2ff2
Compare
Author
|
@Zaimwa9 are we able to get a review on this ? this is currently blocking my team on using flagsmith |
Zaimwa9
requested changes
Feb 25, 2026
Contributor
Zaimwa9
left a comment
Zaimwa9
left a comment
There was a problem hiding this comment.
Thanks a lot for the great contribution. We appreciate.
I just have 3 comments:
- one to fix a pre-existing wrong behavior
- a potentital clean-up
- changelog, that's on us 🙇
…add new test cases for dot notation
Author
|
Should be good to go @Zaimwa9, thanks for the quick look ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
jsonpath has a security exploit being flagged by snyk and other dependency vulnerability detection tools (GHSA-87r5-mp6g-5w5j)
jsonpath has also not been updated in 12 years, and it's probably time to move to a modern equivalent. JSONPath-Plus is a stand in replacement (for the most part) of jsonpath with a variety of upgrades and regularly maintained. This is also the recommendation from the github advisory.
The solution